Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#2017 editor #2265

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Feature/#2017 editor #2265

merged 9 commits into from
Nov 27, 2024

Conversation

jrobinAV
Copy link
Member

@jrobinAV jrobinAV commented Nov 20, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

When locking a data node, providing an "editor_id" only prevents another editor from locking the data node; it does not prevent the other editor from writing the data node.

According to the documentation, it should prevent another editor from writing (appending, uploading) the data node.

Related Tickets & Documents

Checklist

  • Does this solution meet the acceptance criteria of the related issue?
  • Is the related issue checklist completed?
  • Does this PR add unit tests for the developed code?
  • Was the documentation updated, or a dedicated issue for documentation created?

Copy link
Contributor

github-actions bot commented Nov 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19363 16889 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/data/_file_datanode_mixin.py 98% 🟢
taipy/core/data/data_node.py 99% 🟢
taipy/gui_core/_context.py 63% 🟢
TOTAL 87% 🟢

updated for commit: 936b600 by action🐍

@jrobinAV jrobinAV self-assigned this Nov 26, 2024
@jrobinAV jrobinAV merged commit 45cb211 into develop Nov 27, 2024
128 checks passed
@jrobinAV jrobinAV deleted the feature/#2017-editor-id branch November 27, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants