Implement a draw method in scenario config for debug purpose. #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobinAV
added
🧪Testing
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
trgiangdo
previously approved these changes
Nov 29, 2024
| [task_config_1, task_config_2, task_config_3], | ||
| [dn_config_5], | ||
| ) | ||
| scenario_cfg.draw() |
There was a problem hiding this comment.
We can assert the path exists when running this test and similarly for other draw tests
There was a problem hiding this comment.
matplotlib won't be installed in GitHub. So it should do nothing. I don't know how to test that, then.
Co-authored-by: Đỗ Trường Giang <do.giang@avaiga.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
A draw method has been implemented to export a scenario config graph as a PNG file.
The method requires
matplotlibto be installed to run. However,matplotlibshould be installed independently from taipy as it is not a taipy dependency.Related Tickets & Documents
Checklist
We encourage you to keep the code coverage percentage at 80% and above.