Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart refresh column but no data #2314

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

FredLL-Avaiga
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

resolves #2302

fix selector y padding
relates to #2305

Related Tickets & Documents

How to reproduce the issue

import pandas as pd

import taipy.gui.builder as tgb
from taipy.gui import Gui

df = pd.DataFrame(
    {
        "class": ["a", "b", "c", "d", "e"],
        "number_sales": [100, 200, 150, 180, 220],
        "amount_sales": [1503, 2560, 2009, 2302, 2708],
    }
)

sales_display = "number_sales"

with tgb.Page() as bug_chart:
    tgb.toggle("{sales_display}", lov=["number_sales", "amount_sales"])
    tgb.chart(
        data="{df}",
        type="bar",
        x="class",
        y="{sales_display}",
        rebuild=True,
    )

if __name__ == "__main__":
    Gui(page=bug_chart).run(title="2302 [🐛 BUG] Issue when rebuilding bar charts")

resolves #2302
fix selector y padding
relates to #2305
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 💥Malfunction Addresses an identified problem. 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End labels Dec 10, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Dec 10, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 51.87376725838264%

St.
Category Percentage Covered / Total
🔴 Statements 51.87% 263/507
🔴 Branches 21.61% 67/310
🔴 Functions 14.66% 17/116
🔴 Lines 53.19% 242/455

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from f8d151d

Copy link
Contributor

github-actions bot commented Dec 10, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19486 16952 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f8d151d by action🐍

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.095114194854%

St.
Category Percentage Covered / Total
🟢 Statements
87.42% (+0.11% 🔼)
3476/3976
🟡 Branches
69.1% (-0.03% 🔻)
2390/3459
🟢 Functions
83.29% (+0.26% 🔼)
643/772
🟢 Lines
87.88% (+0.1% 🔼)
3218/3662
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / Chart.tsx
61.4% (+1.17% 🔼)
30.99% (-0.28% 🔻)
60.98% (+2.44% 🔼)
61.18% (+1.02% 🔼)

Test suite run success

701 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from f8d151d

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

@FredLL-Avaiga FredLL-Avaiga merged commit 9cc59f2 into develop Dec 10, 2024
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#2302-chart-refresh-col branch December 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 💥Malfunction Addresses an identified problem. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Issue when rebuilding bar charts
2 participants