-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue about not publishing data node updates #2316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobinAV
commented
Dec 10, 2024
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
jrobinAV
requested review from
trgiangdo,
joaoandre-avaiga,
toan-quach and
FlorianJacta
December 11, 2024 11:45
jrobinAV
added
Core
Related to Taipy Core
🟥 Priority: Critical
Must be addressed as soon as possible
Core: Job & Orchestrator
Core: Data node
💥Malfunction
Addresses an identified problem.
labels
Dec 11, 2024
trgiangdo
reviewed
Dec 11, 2024
joaoandre-avaiga
previously approved these changes
Dec 12, 2024
toan-quach
previously approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: Đỗ Trường Giang <do.giang@avaiga.com>
jrobinAV
dismissed stale reviews from toan-quach and joaoandre-avaiga
via
December 12, 2024 15:15
4ed94c7
toan-quach
approved these changes
Dec 13, 2024
trgiangdo
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Core: Data node
Core: Job & Orchestrator
Core
Related to Taipy Core
💥Malfunction
Addresses an identified problem.
🟥 Priority: Critical
Must be addressed as soon as possible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Data node update events were not properly published when the update came from a task execution in standalone mode.
When a data node is written, 4 update events should be published:
When the writing was made by a task execution, the events were published into a Notifier specific to the process, while it MUST be published to the main application Notifier.
Related Tickets & Documents
How to reproduce the issue
branches or releases
Check list