Convert control codepoints into zero width space during shaping (#17004)

AvaloniaUI · Sep 14, 2024 · 2e83ac1 · 2e83ac1
1 parent d5f0188
commit 2e83ac1
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/Skia/Avalonia.Skia/TextShaperImpl.cs b/src/Skia/Avalonia.Skia/TextShaperImpl.cs
@@ -14,7 +14,10 @@ namespace Avalonia.Skia
 {
     internal class TextShaperImpl : ITextShaperImpl
     {
+        private const uint ZeroWidthSpace = '\u200b';
+
         private static readonly ConcurrentDictionary<int, Language> s_cachedLanguage = new();
+
         public ShapedBuffer ShapeText(ReadOnlyMemory<char> text, TextShaperOptions options)
         {
             var textSpan = text.Span;
@@ -68,6 +71,16 @@ public ShapedBuffer ShapeText(ReadOnlyMemory<char> text, TextShaperOptions optio
 
                     var glyphCluster = (int)(sourceInfo.Cluster);
 
+                    if (glyphIndex == 0)
+                    {
+                        var codepoint = Codepoint.ReadAt(textSpan, glyphCluster, out _);
+
+                        if (codepoint.GeneralCategory == GeneralCategory.Control)
+                        {
+                            glyphIndex = options.Typeface.GetGlyph(ZeroWidthSpace);
+                        }
+                    }
+
                     var glyphAdvance = GetGlyphAdvance(glyphPositions, i, textScale) + options.LetterSpacing;
 
                     var glyphOffset = GetGlyphOffset(glyphPositions, i, textScale);