Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitButton should have HotKey property like Button and DropDownButton #14002

Closed
ionite34 opened this issue Dec 20, 2023 · 2 comments · Fixed by #14638
Closed

SplitButton should have HotKey property like Button and DropDownButton #14002

ionite34 opened this issue Dec 20, 2023 · 2 comments · Fixed by #14638
Labels
enhancement help-wanted A contribution from the community would be most welcome.

Comments

@ionite34
Copy link

ionite34 commented Dec 20, 2023

Is your feature request related to a problem? Please describe.

Currently SplitButton is the only Button that does not support the HotKey property, and setting the HotKeyManager.HotKey attached property does not work when the view is loaded and unloaded (Button handles this by resetting the property in Button.OnAttachedToLogicalTree)

Describe the solution you'd like

Copy over the HotKeyProperty and OnAttachedToLogicalTree handling from Button to SplitButton, linking the HotKey to the main SplitButton.Command

@timunie
Copy link
Contributor

timunie commented Dec 21, 2023

Sounds like an oversight to me. A PR is welcome. Use AddOwner when adding the StyledProperty

@timunie timunie added the help-wanted A contribution from the community would be most welcome. label Dec 21, 2023
@robloo
Copy link
Contributor

robloo commented Dec 30, 2023

Yea, I missed this with the initial implementation. I'll check WinUI as well but this shouldn't be an issue to add. I'll add it to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help-wanted A contribution from the community would be most welcome.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants