Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SplitButton): Add HotKey #14638

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Feb 18, 2024

Added HotKey property to SplitButton like Button and DropDownButton

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #14002

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0045040-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@robloo
Copy link
Contributor

robloo commented Feb 20, 2024

Thanks! didn't have a chance to get to this one myself

/// <summary>
/// Gets or sets an <see cref="KeyGesture"/> associated with this control
/// </summary>
public KeyGesture? HotKey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these docs should be inherited from button. Although I didn't inherit any of the other comments which I probably should have.

@maxkatz6 maxkatz6 added this pull request to the merge queue Mar 6, 2024
Merged via the queue into AvaloniaUI:master with commit 2dbe9e0 Mar 6, 2024
6 checks passed
@workgroupengineering workgroupengineering deleted the features/Controls/SplitButton branch March 6, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SplitButton should have HotKey property like Button and DropDownButton
4 participants