Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce static AssetLoader #11190

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Introduce static AssetLoader #11190

merged 2 commits into from
Apr 30, 2023

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

  1. Rename instance-class impl AssetLoader to StandardAssetLoader and make it internal.
  2. Add public and static AssetLoader with supported APIs
  3. Update assetloader tests to use StandardAssetLoader properly without static global state.
  4. Update IAssetLoader obsolete message (in another PR).

Checklist

Breaking changes

AssetLoader class is now internal and renamed to StandardAssetLoader. Static API covers all supported use-cases.

Fixed issues

Fixes #11155

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0034047-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@kekekeks kekekeks added this pull request to the merge queue Apr 30, 2023
Merged via the queue into master with commit c4da74a Apr 30, 2023
@kekekeks kekekeks deleted the stable-AssetLoader branch April 30, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a stable API for AssetLoader
3 participants