-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make miscellaneous Avalonia.Controls APIs internal #11477
Make miscellaneous Avalonia.Controls APIs internal #11477
Conversation
Was added in #9803 for `TransitioningContentControl` but is no longer needed (and anyway it should be called `OnContentChanged` if we want to keep it).
Can probably be removed.
Can probably be removed.
Should only be needed for unit tests.
1. They don't follow naming conventions 2. If we're going to expose them, why just `protected`? 3. If we do it, we should do it on all controls
Should only be needed for unit tests.
Unused API and I'm not sure we want to expose an extension point here.
Can probably be removed?
This feature is no longer supported.
You can test this PR using the following package version. |
For pseudoclass constants, protected is useful for derived controls. However, it's been an open issue for a while how these should be standardized (along with template part name constants). This definitely needs to be followed up with post 11.0 with a naming and standardization pass along with exposing them to derived controls. Relates to #9093 |
You can test this PR using the following package version. |
Merging, as there will be a couple of conflicts with other PRs. If anybody noticed anything that should be reverted - please create an issue. |
What does the pull request do?
Made a bunch of APIs in Avalonia.Controls internal (and in a couple of cases delete obsolete APIs). Should be mostly uncontroversial - but as ever let us know if we've hidden something you need!
Check out the commit list to see details of the individual changes.