Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make miscellaneous Avalonia.Controls APIs internal #11477

Merged
merged 22 commits into from
May 22, 2023

Conversation

grokys
Copy link
Member

@grokys grokys commented May 22, 2023

What does the pull request do?

Made a bunch of APIs in Avalonia.Controls internal (and in a couple of cases delete obsolete APIs). Should be mostly uncontroversial - but as ever let us know if we've hidden something you need!

Check out the commit list to see details of the individual changes.

grokys added 21 commits May 22, 2023 11:22
Was added in #9803 for `TransitioningContentControl` but is no longer needed (and anyway it should be called `OnContentChanged` if we want to keep it).
Can probably be removed.
Can probably be removed.
Should only be needed for unit tests.
1. They don't follow naming conventions
2. If we're going to expose them, why just `protected`?
3. If we do it, we should do it on all controls
Should only be needed for unit tests.
Unused API and I'm not sure we want to expose an extension point here.
Can probably be removed?
This feature is no longer supported.
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0035192-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@robloo
Copy link
Contributor

robloo commented May 22, 2023

For pseudoclass constants, protected is useful for derived controls. However, it's been an open issue for a while how these should be standardized (along with template part name constants).

This definitely needs to be followed up with post 11.0 with a naming and standardization pass along with exposing them to derived controls. Relates to #9093

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0035219-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@maxkatz6
Copy link
Member

Merging, as there will be a couple of conflicts with other PRs. If anybody noticed anything that should be reverted - please create an issue.

@maxkatz6 maxkatz6 added this pull request to the merge queue May 22, 2023
Merged via the queue into master with commit 439a5b8 May 22, 2023
@maxkatz6 maxkatz6 deleted the refactor/grokys-avalonia-controls-internalize branch May 22, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants