Event Renaming (Removing Type Prefix)

[robloo]

What does the pull request do?

Standardizes event naming by removing the type prefix. See the full analysis in the issue #10663 here.

What is the current behavior?

Events are improperly named and don't follow WPF/WinUI.

What is the updated/expected behavior with this PR?

Events are properly named removing the type prefix and follow WPF/WinUI where possible.

How was the solution implemented (if it's not obvious)?

Obvious

Checklist

• [ ] Added unit tests (if possible)?
• [ ] Added XML documentation to any related classes?
• [ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Yes, event names have changed which will break compilation.

• ContextMenu
  • ContextMenuClosing -> Closing
  • ContextMenuOpening -> Opening
• MenuBase
  • MenuClosed -> Closed
  • MenuOpened -> Opened

Obsoletions / Deprecations

None

Fixed issues

Closes #10663

[robloo]

Window is the only other type I can find (searched routed events) that has this issue

Avalonia/src/Avalonia.Controls/Window.cs

Lines 157 to 167 in 74a0f1d

	/// <summary>
	/// Routed event that can be used for global tracking of window destruction
	/// </summary>
	public static readonly RoutedEvent<RoutedEventArgs> WindowClosedEvent =
	RoutedEvent.Register<Window, RoutedEventArgs>("WindowClosed", RoutingStrategies.Direct);
	/// <summary>
	/// Routed event that can be used for global tracking of opening windows
	/// </summary>
	public static readonly RoutedEvent<RoutedEventArgs> WindowOpenedEvent =
	RoutedEvent.Register<Window, RoutedEventArgs>("WindowOpened", RoutingStrategies.Direct);

This appears to be a special-case so let me know if it needs to change as well. I would like to keep things consistent.

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0035527-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

[grokys]

LGTM, @maxkatz6 says we should consider ContextMenu obsolete and not change it but I think that given that we're changing MenuBase here we might as well do it.

I was going to suggest adding compatibility aliases for the old event naming but given the recent amount of breaking changes made by us I fear I'll be laughed out of town, so I won't do that :D