Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework ITextInputMethodClient #11848

Merged
merged 28 commits into from
Jun 30, 2023
Merged

Rework ITextInputMethodClient #11848

merged 28 commits into from
Jun 30, 2023

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Jun 21, 2023 •
edited
Loading

What does the pull request do?

This PR adjusts ITextInputMethodClient so all platforms consume a unified API

  • Add TextSelection Get, Set
  • Remove CompositionRegion
  • Remove ITextEditable
  • Separate selection from surrounding text to be able to update them individually

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036822-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald changed the title Rework ITextInputMethodClient [WIP] Rework ITextInputMethodClient Jun 22, 2023
@Gillibald Gillibald force-pushed the textInputMethodClientRework branch from 4e0792c to be9a26c Compare June 23, 2023 08:22
@Gillibald Gillibald changed the title [WIP] Rework ITextInputMethodClient Rework ITextInputMethodClient Jun 23, 2023
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036926-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036936-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036943-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036947-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036981-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036983-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0036997-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald requested a review from a team June 27, 2023 08:38
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037007-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@emmauss emmauss requested a review from kekekeks June 28, 2023 08:53
@Gillibald Gillibald added this to the 11.0 milestone Jun 29, 2023
@maxkatz6 maxkatz6 enabled auto-merge June 29, 2023 20:42
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037119-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037137-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037185-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037219-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037246-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Jun 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 30, 2023
@danwalmsley danwalmsley added this pull request to the merge queue Jun 30, 2023
Merged via the queue into AvaloniaUI:master with commit fddb07e Jun 30, 2023
@Numpsy Numpsy mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

@kekekeks kekekeks kekekeks approved these changes

Assignees
No one assigned
Labels
breaking-change release-blocker
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Gillibald @avaloniaui-team @kekekeks @maxkatz6 @danwalmsley @emmauss