Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hold Gesture size and event improvements #12879

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Hold Gesture size and event improvements #12879

merged 11 commits into from
Sep 25, 2023

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Sep 13, 2023 •
edited
Loading

What does the pull request do?

Reduces the Hold gesture size. Hold gesture is now handled on all controls using a class handler, as opposed to adding handlers when each control is attached.

Text selection now shows the context menu after a range selection completes. Holding on an existing selection no longer updates the selection, but opens the context menu.

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #12808 . Text selection needs to be improved for touch input in general.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039460-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@emmauss emmauss marked this pull request as draft September 15, 2023 19:22
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039718-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@emmauss emmauss marked this pull request as ready for review September 22, 2023 11:13
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039800-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

maxkatz6
maxkatz6 reviewed Sep 24, 2023
View reviewed changes
src/Avalonia.Base/Input/HoldingRoutedEventArgs.cs Outdated
@@ -20,6 +20,8 @@ public class HoldingRoutedEventArgs : RoutedEventArgs
/// </summary>
public PointerType PointerType { get; }

public PointerEventArgs? PointerEventArgs { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might conflict with #11299 later, so I would keep it internal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039941-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 enabled auto-merge September 25, 2023 07:55
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039959-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Sep 25, 2023
Merged via the queue into master with commit 3471620 Sep 25, 2023
@maxkatz6 maxkatz6 deleted the hold_improvements branch September 25, 2023 12:02
@emmauss emmauss mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextBox text selection not working properly
3 participants
@emmauss @avaloniaui-team @maxkatz6