Data grid handled events #13680
Merged
Data grid handled events #13680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another solution would be to remove the |
|
I forgot to add a motivation for this. Avalonia has a weird behavior where when I select multiple items in the DataGrid and then I would like to drag all items, they are deselected first. This deselection is caused by mouse down even before the app realizes I am dragging. It should happen on mouse up. It was possible to workaround this, but after this change, it can't be done. |
maxkatz6
approved these changes
Nov 25, 2023
maxkatz6
added
the
backport-candidate-11.0.x
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
* DataGridCell - ignore handled events * DataGridCell - ignore handled events * revert
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
There was a breaking change in Avalonia 11.0 where some events can't be canceled (#9918). This PR tries to fix DataGridCell PointerPressed.
What is the current behavior?
You can't handle the event in a way that would prevent the bubbling. It was handled before on the framework level. Now this needs to be handled by each component.
What is the updated/expected behavior with this PR?
If the event has been handled the bubbling should be canceled.
Checklist
Breaking changes
I don't think there should be any raised handled event that should be still taken into account for this.
Obsoletions / Deprecations
Fixed issues