fix:(TimePicker): TimePicker should respect *Alignment #13691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erticalAlignment properties set in XAML
|
I'm not sure how to align the text. It is currently on top center. Is it / bound to ContentAlignment? Should it even be bound to ContentAlignment or is this by design? |
I have the same doubt as you, but I maintained the current behavior because I thought it was by design. |
|
looking further the Top-position is not hard coded, so it should be easy to write a selector for it if needed. The centering is by design. So I think we may want to leave this part untouched for now. |
maxkatz6
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimePicker should respect HorizontalAlignment and VerticalAlignment properties set in XAML
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #13658