feat(DevTools): Add LaunchView property to DevToolsOptions #14008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow set the initial diagnostic view when launch DevTools
|
You can test this PR using the following package version. |
MrJul
reviewed
Dec 21, 2023
| /// <summary> | ||
| /// Diagnostic views available in DevTools | ||
| /// </summary> | ||
| public enum DevToolsViews |
There was a problem hiding this comment.
Naming: only flags enums are usually plural.
This probably should be DevToolsViewType/Kind or something similar.
MrJul
reviewed
Dec 21, 2023
| /// <summary> | ||
| /// Set <see cref="DevToolsViews"/> that show when DevTools launch | ||
| /// </summary> | ||
| public DevToolsViews LaunchView { get; init; } |
There was a problem hiding this comment.
Why init? All other options are mutable.
There was a problem hiding this comment.
I think DevToolsOptions should be immutable. I proposed it for v 12.
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Allow set the initial diagnostic view when launch DevTools
What is the current behavior?
When launch DevTools alwayes show
Logical ViewWhat is the updated/expected behavior with this PR?
Allow customize initial diagnostic view when launch DevTools
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Close #14006