Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #14211 BoxShadow.ToString() behavior #14228

Merged

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Jan 16, 2024

What does the pull request do?

The ToString() method of BoxShadow to not allow to Parse it again. It throw an exception.

What is the current behavior?

When invoke BoxShadow.ToString() if a any Property has default value it is not appended

What is the updated/expected behavior with this PR?

When invoke BoxShadow.ToString()

  • OffsetX and OffsetY is always append
  • if Spread is not zero and Blur is zezo , Blur is append

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #14211

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0043634-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@workgroupengineering workgroupengineering marked this pull request as ready for review January 16, 2024 13:29
@maxkatz6 maxkatz6 added this pull request to the merge queue Feb 7, 2024
Merged via the queue into AvaloniaUI:master with commit 7106b37 Feb 7, 2024
6 checks passed
@workgroupengineering workgroupengineering deleted the fixes/core/BoxShadow branch February 7, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoxShadow.ToString() do not allow to parse it again (exception thrown)
3 participants