Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show adorner while hovering any part of a control's TreeViewItem in DevTools #14231

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

AtomCrafty
Copy link
Contributor

@AtomCrafty AtomCrafty commented Jan 16, 2024

What does the pull request do?

Changes the way the overlay adorner is triggered when hovering over an item in the DevTools control tree.

What is the current behavior?

The overlay is only displayed while the mouse is over the actual text (control type, class list or element name).

What is the updated/expected behavior with this PR?

Hovering any part of a control's TreeViewItem in DevTools now causes the overlay to display.

How was the solution implemented (if it's not obvious)?

Instead of individual event handlers for the StackPanel in each TreeViewItem there now only exists one handler for the entire TreeView that uses e.Source to determine which TreeViewItem the pointer event came from.

Fixed issues

Fixes #14230

@AtomCrafty AtomCrafty force-pushed the devtools-adorner-hover branch from 58611f4 to 8269033 Compare January 16, 2024 15:15
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0043644-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@AtomCrafty AtomCrafty changed the title Show adorner while hovering any part of the control's TreeViewItem in DevTools Show adorner while hovering any part of a control's TreeViewItem in DevTools Jan 16, 2024
@maxkatz6 maxkatz6 added this pull request to the merge queue Jan 17, 2024
Merged via the queue into AvaloniaUI:master with commit 1c792b2 Jan 17, 2024
6 checks passed
@BAndysc BAndysc mentioned this pull request Mar 8, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevTools overlay only shows while hovering text in control tree
3 participants