Fix issue that breaking IME discards input buffer #14433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Feb 8, 2024
|
You can test this PR using the following package version. |
Gillibald
added
backport-candidate-11.0.x
grokys
added
backported-11.1.x
and removed
backport-candidate-11.1.x
|
Will this get backported 11.0.x? |
|
|
@cla-avalonia agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Breaking IME composition mode discards input composition buffer on windows Korean IME
What is the current behavior?
character is removed when If IME composition mode ends (via space, tab, number, by non-ime keys)
What is the updated/expected behavior with this PR?
composition ends, keep the character(s)
How was the solution implemented (if it's not obvious)?
breaking IME composition puts WM_IME_COMPOSITION to the messaging loop with empty result str (GCS_RESULTSTR)
so it must be handled within WM_IME_ENDCOMPOSITION message.
FYI: One thing I've noticed is that WM_KILLFOCUS interrupts the composition state, but in my experience with IME it shouldn't. It should only be solely handled by WM_IME_*. But I think this requires a significant amount of refactoring.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues