Fixes relative brush mapping mode #14598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dialGradientBrush
|
You can test this PR using the following package version. |
jmacato
approved these changes
Feb 13, 2024
|
You can test this PR using the following package version. |
…/Avalonia into fixes/relative-mapping-mode-2
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 13, 2024
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When designing Avalonia APIs and converting
BrushMappingMode.RelativeToBoundingBoxtoRelativeUnit.Relativethe "to boundling box" part was lost in translation.So if a graphics primitive submitted to DrawingContext has a non-0:0 origin, the rendering is incorrect and sometimes doesn't render anything at all.
Fixes #10972
Fixes #3995
This PR also fixes
RadialGradientBrush.Radiusbeing forcefully treated as a relative value even if the rest of the brush is using absolute mapping mode.This PR also adds separate RadiusX/RadiusY properties.