Seek stream before loading icon #14830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Mar 6, 2024
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
removed
the
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Seek stream before loading icon.
What is the current behavior?
After
bitmap.Save(memoryStream), the position of stream will be set to the end, which leads toSystem.IO.EndOfStreamException: Unable to read beyond the end of the streamin the followingCreateIconImplcall.What is the updated/expected behavior with this PR?
Seek stream before loading icon to fix this issue.