Fix TransformOrigin for brushes #15037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 19, 2024
maxkatz6
added
the
backport-candidate-11.1.x
jp2masa
reviewed
Mar 20, 2024
| var transformOrigin = content.TransformOrigin.ToPixels(targetRect); | ||
| var offset = Matrix.CreateTranslation(transformOrigin); | ||
|
|
||
| transform *= -offset * content.Transform.Value * offset; |
There was a problem hiding this comment.
Does this actually work? I think -offset also flips X and Y coordinates, but the test images won't catch this because they are symmetric in X and Y.
There was a problem hiding this comment.
TransformOrigin mainly used to move the origin to some rotation point
The math is correct here
There was a problem hiding this comment.
Sorry, only noticed now that -offset actually means the inverse of offset. I think it would be more efficient to CreateTranslation(-transformOrigin), but performance is probably not a problem here.
Gillibald
added a commit
that referenced
this pull request
Mar 27, 2024
This reverts commit 4f8f46c.
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues