Add FuncValueConverter with parameter support #15323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
jp2masa
reviewed
Apr 11, 2024
| @@ -42,4 +42,44 @@ public FuncValueConverter(Func<TIn?, TOut> convert) | |||
| throw new NotImplementedException(); | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// A general purpose <see cref="IValueConverter"/> that uses a <see cref="Func{TIn, TParam, TResult}"/> | |||
|
You can test this PR using the following package version. |
jmacato
approved these changes
Apr 11, 2024
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 20, 2024
* Add FuncValueConverter with parameter support * Fix summary comment * Fix summary comment * Add Equal and NotEqual converters to a ObjectConverters class * Fix condition for Equal * Added ObjectConverters unit tests
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds support for converter parameter into
FuncValueConverter<TIn, TParam, TOut>and uses it to implementObjectConverters.EqualandObjectConverters.NotEqualconvertersWhat is the current behavior?
No support for converter parameter in FuncValueConverter
What is the updated/expected behavior with this PR?
FuncValueConverter can be declared with parameter support in Func
How was the solution implemented (if it's not obvious)?
Created new version of generic
FuncValueConverter<TIn, TParam, TOut>Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues