Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable on Avalonia.Android project #15331

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Enable nullable on Avalonia.Android project #15331

merged 2 commits into from
Apr 12, 2024

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

As title says.
For some reason this project wasn't already updated to use nullable by default.
It was causing lots of inconvenience for a while.

This PR doesn't change logic. Some new exceptions just replace less specific NRE that could happen before.
Backporting it just so we can avoid thousands of conflicts on future backports.

@maxkatz6 maxkatz6 added area-infrastructure Issues related to CI/tooling infrastructur os-android backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 12, 2024
@maxkatz6 maxkatz6 merged commit 6258df5 into master Apr 12, 2024
2 of 10 checks passed
@maxkatz6 maxkatz6 deleted the android-nullabe branch April 12, 2024 01:03
maxkatz6 added a commit that referenced this pull request Apr 20, 2024
* Enable nullable on Avalonia.Android project

* More specific exception
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Issues related to CI/tooling infrastructur backported-11.1.x os-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant