Disable WinFormsAvaloniaControlHost in design mode #16296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
maxkatz6
added
bug
os-windows
backport-candidate-11.1.x
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thank you very much for the quick reactions. Interestingly, your macOS integration tests (merge queue) fail although I only changed a Windows only component 🙃 |
|
@daniel-lerch there are some flaky tests, especially on macOS. And when one fails - the rest will fail too. Unfortunately, it's way too difficult to setup integrational tests well. |
maxkatz6
pushed a commit
that referenced
this pull request
Aug 12, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This pull request disables the creation of an
EmbeddableControlRootinWinFormsAvaloniaControlHostwhen it is in design mode, i.e. run by the Windows Forms designer.Furthermore, I added a rectangle with a caption Avalonia control is disabled in design mode. which is rendered in design mode only to inform help developers find their control in the designer and give them a hint why they cannot see their Avalonia control.
What is the current behavior?
When you add a
WinFormsAvaloniaControlHostto your Form, the control throws an exception.First, you will be shown this message box by Visual Studio every time you open the designer which is very annoying.
Secondly, in place of your control host the designer will render a big error message which is hard to ignore while using the designer for other controls.
What is the updated/expected behavior with this PR?
Now, the control does not throw an exception anymore and the designer instead shows a subtle hint that the Avalonia control is disabled.
How was the solution implemented (if it's not obvious)?
Just two simple if conditions. If
WinFormsAvaloniaControlHostshould become more complex in the future it might make sense to split the runtime and the designer implementation into two different classes.Checklist
Fixed issues
Fixes #16288