Fix - Make empty text run content empty #16693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
emmauss
force-pushed
the
empty_text_run_fix
branch
from
947f39c to
88d0ded
Compare
|
You can test this PR using the following package version. |
maxkatz6
added
bug
backport-candidate-11.1.x
emmauss
force-pushed
the
empty_text_run_fix
branch
from
88d0ded to
95a7871
Compare
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Make empty textruns have empty content. That is, return empty char buffer when Text is requested.
What is the current behavior?
Currently, empty text runs are run with only 1 whitespace char, " ". This is indistinguishable from a textrun created by user with a space, and may cause issues with text clients that uses SurroundingText for prediction, especially on some android versions.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #16656 . #16666 fixes a similar input issue on older android devices.