-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CalendarDatePicker - use CustomDateFormatString for parsing the text input #17465
CalendarDatePicker - use CustomDateFormatString for parsing the text input #17465
Conversation
You can test this PR using the following package version. |
97e3394
to
3ece70e
Compare
You can test this PR using the following package version. |
3ece70e
to
464e85e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A missing condition aside, this looks good, thank you!
464e85e
to
ef813e2
Compare
You can test this PR using the following package version. |
You can test this PR using the following package version. |
What does the pull request do?
This PR looks for possible existing CustomDateFormatString and use it for parsing text input. Also the watermark will use now the CustomDateFormatString.
What is the current behavior?
The CustomDateFormatString is ignored and will also throw exceptions. See #17291
What is the updated/expected behavior with this PR?
Now exception is throen and the text is parsed to the excpected DateTime.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #17291