Fix Gtk open file dialog returns folder #17500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Gtk open file dialog shows folders in recent list. User can select folder and Gtk will return its path. Avalonia open file dialog should return only files. Fix is checking if Gtk path is real file.
What is the current behavior?
Gtk open file dialog returns folder path. Avalonia creates
FileInfo
from this path and returnsIStorageFile
to user. Then user can callIStorageFile.Open*
methods or manually call any .NET file API and will get exception because path is folder.What is the updated/expected behavior with this PR?
Avalonia checks if path is file and returns only files.
How was the solution implemented (if it's not obvious)?
Fix is checking if Gtk path is real file by
File.Exists()
.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues