Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17675 - AfterPlatformServicesSetup callbacks are not called by the A… #17676

Merged

Conversation

gentledepp
Copy link
Contributor

…fterApplicationSetup callbacks anymore

What does the pull request do?

What is the current behavior?

This PR fixes the issue #17675

What is the updated/expected behavior with this PR?

AfterApplicationServicesSetup delegate is not errorneously combined with the AfterPlatformServicesSetup anymore.

How was the solution implemented (if it's not obvious)?

... it is obvious, believe me ;-)

Checklist

  • Added unit tests (if possible)?
  • Added XML documentation to any related classes?
  • Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation
    This was just a one-line typo fix. No doc required I guess.

Breaking changes

None

Obsoletions / Deprecations

Fixed issues

Fixes #17675

…d by the AfterApplicationSetup callbacks anymore
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0053668-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Dec 3, 2024

  • All contributors have signed the CLA.

@gentledepp
Copy link
Contributor Author

@cla-avalonia agree

@maxkatz6 maxkatz6 added bug backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Dec 3, 2024
@maxkatz6 maxkatz6 added this pull request to the merge queue Dec 3, 2024
@maxkatz6
Copy link
Member

maxkatz6 commented Dec 3, 2024

Good find

@gentledepp
Copy link
Contributor Author

glad to be of service ;-)

Merged via the queue into AvaloniaUI:master with commit 7210eff Dec 3, 2024
11 checks passed
maxkatz6 pushed a commit that referenced this pull request Dec 19, 2024
@maxkatz6 maxkatz6 added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch backported-11.2.x bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AfterPlatformServicesSetup callbacks are called by AfterApplicationSetupCallback
4 participants