TextBox: update command states on selection changes #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danwalmsley
pushed a commit
that referenced
this pull request
May 19, 2021
…only-textbox TextBox: update command states on selection changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes #5924
Current logic to update context menu commands relies on the fact that
OnLostFocusevent handler of theTextBoxwill be invoked when context menu is opening. But for readonlyTextBoxthere are no active context menu items, soFocusManagescan't focus anything and command states do not update.What is the current behavior?
Context menu
Copycommand of the readonlyTextBoxis disabledWhat is the updated/expected behavior with this PR?
Context menu
Copycommand of the readonlyTextBoxis enabledHow was the solution implemented (if it's not obvious)?
This PR adds command state updates when
TextBoxselection is changed.Checklist
Fixed issues
Fixes #5924