Do not copy UWP behavior with ListBoxItem horizontal alignment #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea, anyone using WinUI 2 library or WinUI 3 will have stretch as the default. That was a surprisingly difficult conversation and it represents perfectly everything wrong with WinUI development these days: microsoft/microsoft-ui-xaml#1402 Anyway, seeing this simple commit with no fuss because everyone knows its better is so refreshing. |
jmacato
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Yeah this makes more sense :) Let's wait for @danwalmsley 's approval before merging
|
Here is my analysis of breaking changes. Bottom line, extremely minimal. |
|
got approval from @danwalmsley :) |
danwalmsley
pushed a commit
that referenced
this pull request
Dec 20, 2021
…ment Do not copy UWP behavior with ListBoxItem horizontal alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
In Default theme default ListBoxItem horizontal alignment is Stretch. Same as in WPF.
In Fluent theme we copy UWP behavior and set Left value instead. Note, newer WinUI versions use Stretch as well.
Why is it a problem?
https://stackoverflow.com/questions/43094395/how-to-stretch-listviewitem-in-listview
microsoft/microsoft-ui-xaml#1402
What is the updated/expected behavior with this PR?
Do not override default value in theme. Which makes it "Stretch" value (HorizontalAlignment enum default value).
Breaking changes
Technically it is a styling breaking change.