Make ComboBox dropdown respect scale transform #8042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes #7147 by making
ComboBox
's dropdown respect theComboBox
scale transform.Popup.InheritsTransform
propertyComboBox
template(s)Transform
property toPopupRoot
andOverlayPopupHost
LayoutTransformControl
toPopupRoot
andOverlayPopupHost
's template, with its transform bound to thisTransform
propertyPopup
placement target to thePopupRoot.Transform
/OverlayPopupHost.Transformproperty when
InheritsTransform` is setPopupRoot
/OverlayPopupHost
's min/max/width/height settingBindConstraints
method was removed fromIPopupHost
and the relevant properties were instead added to the interface and set fromPopup
Note that only scale transforms are currently handled correctly; rotate transforms are not handled correctly. This is because our popup positioning API (which comes from Wayland) makes applying rotate transforms rather difficult as the popup position is based on a
Rect
on the parent window. It will probably be possible to correctly handle rotate transforms here, but should probably be done in a separate PR if anyone fancies tackling it - as it may be tricky.Breaking Changes
Changes the API of the
IPopupHost
interface.Fixed issues
Fixes #7147