Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup runtime platform classes #8183

Merged
merged 21 commits into from
Jun 8, 2022
Merged

Cleanup runtime platform classes #8183

merged 21 commits into from
Jun 8, 2022

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented May 25, 2022 •
edited
Loading

What does the pull request do?

  1. Merges PlatformSupport project into the Avalonia.Base. AppBuilder was moved to the Avalonia.Controls. PlatformSupport was previously added temporary to simplify new android backends and before core libraries were merged.
  2. Where possible NET6/NETSTANDARD implementations of runtime platform interfaces were used. To be specific:
  • Uses NativeLibrary to load library or export proc. Only NET6 (technically netcore3.0+, but still 'no' for us).
  • RuntimeFeature.IsDynamicCodeSupported to know if it's possible to load assembly or not. Only NET6 (was added with netstandard2.1).
  • Marshal.AllocHGlobal instead of mmap on linux in UnmanagedBlob. Reverted after a discussion.
  1. Removes legacy xamarin solution configuration (iPhoneSimulator, Ad-Hoc...). They are not used with new mobile backend, and we don't need them anyway.
  2. Deprecated overload of AppBuilderBase.Start was removed (deprecated since 0.9.0)

Breaking changes

Only binary and only in nightly builds. So, no.

@maxkatz6 maxkatz6 requested a review from kekekeks May 25, 2022 04:03
@maxkatz6 maxkatz6 changed the title Cleanup platformsupport Cleanup runtime platform classes May 25, 2022
@maxkatz6 maxkatz6 requested a review from a team May 26, 2022 03:25
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0020671-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0020694-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@maxkatz6
Merge branch 'master' into cleanup-platformsupport
8d6c8cf 
# Conflicts:
#	src/Avalonia.Base/Properties/AssemblyInfo.cs
#	src/Avalonia.PlatformSupport/Avalonia.PlatformSupport.csproj
@maxkatz6 maxkatz6 requested a review from kekekeks May 30, 2022 05:03
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0020754-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 force-pushed the cleanup-platformsupport branch from f09fc26 to 0488d0d Compare June 3, 2022 03:28
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0021076-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 89d0f1d into master Jun 8, 2022
@maxkatz6 maxkatz6 deleted the cleanup-platformsupport branch June 8, 2022 07:00
@maxkatz6 maxkatz6 mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokys grokys grokys approved these changes

@kekekeks kekekeks Awaiting requested review from kekekeks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxkatz6 @avaloniaui-team @kekekeks @grokys