Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan backend (Cherry Pick some changes for RC) #9739

Closed
wants to merge 13 commits into from
Closed

Vulkan backend (Cherry Pick some changes for RC) #9739

wants to merge 13 commits into from

Conversation

kekekeks
Copy link
Member

@kekekeks kekekeks commented Dec 18, 2022 •
edited by maxkatz6
Loading

Mostly based on #7753 but uses the new infrastructure introduced in #9639

Fixes #4274

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0027738-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@hez2010
Copy link
Contributor

hez2010 commented Dec 19, 2022

If I recalled correctly, Vulkan doesn't support WS_EX_NOREDIRECTIONBITMAP. Will this introduce regressions on Windows?

@kekekeks
Copy link
Member Author

  1. Vulkan backend is optional, apps will still use ANGLE on Windows by default
  2. at some point we'll implement WinUI composition output for Vulkan too (we just need to render into a DXGI surface)

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0027758-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0027763-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0027775-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0027777-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

llfab
llfab reviewed Dec 21, 2022
View reviewed changes
src/Avalonia.Vulkan/VulkanControlBase.cs
typeof(IVulkanSharedDeviceGraphicsContextFeature));
if (feature?.SharedDevice == null)
{
Logger.TryGet(LogEventLevel.Error, "OpenGL")?.Log("VulkanControlBase",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"OpenGL" => "Vulkan"

llfab
llfab reviewed Dec 21, 2022
View reviewed changes
src/Avalonia.X11/X11Platform.cs
/// <summary>
/// Enables Vulkan rendering backend
/// </summary>
public bool UseVulkan { get; set; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fit into what is already there. UseXy is present in all kinds of backends. I wonder whether at some point we do not distribute UseXy into all separate XyPlatformOptions. Anyways fits to how it is done already.

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0027790-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@kekekeks kekekeks changed the title [WIP] Vulkan backend Vulkan backend Dec 27, 2022
@kekekeks kekekeks added this to the 11.0 milestone Mar 8, 2023
@kekekeks kekekeks self-assigned this Mar 8, 2023
@danwalmsley danwalmsley changed the title Vulkan backend Vulkan backend (Cherry Pick some changes for RC) Apr 25, 2023
@maxkatz6 maxkatz6 modified the milestones: 11.0, 11.x Jul 5, 2023
@kekekeks
Copy link
Member Author

kekekeks commented Aug 31, 2023 •
edited
Loading

Superceded by #12737

@kekekeks kekekeks closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llfab llfab llfab left review comments

Assignees

@kekekeks kekekeks

Labels
None yet
Projects
None yet
Milestone
11.x
Development

Successfully merging this pull request may close these issues.

Vulkan Control?
5 participants
@kekekeks @avaloniaui-team @hez2010 @llfab @maxkatz6