Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for latest Avalonia Build #6

Merged
merged 3 commits into from
Feb 4, 2023
Merged

add support for latest Avalonia Build #6

merged 3 commits into from
Feb 4, 2023

Conversation

laolarou726
Copy link
Contributor

Avalonia Nightly Build changed several APIs (most of them are ready for the next preview release). This PR adds support for it.

@laolarou726
Copy link
Contributor Author

For the removal of IsEffectiveValueChange: all changes that get as far as PropertyChanged will be effective value changes.

@SKProCH SKProCH added the enhancement New feature or request label Dec 28, 2022
@SKProCH
Copy link
Member

SKProCH commented Dec 29, 2022

@laolarou726 did you think it should be merged asap, or I should wait till the next Avalonia preview will be released?

@laolarou726
Copy link
Contributor Author

@laolarou726 did you think it should be merged asap, or I should wait till the next Avalonia preview will be released?

I think either is ok? You can wait till next preview release. Currently I'm linking the source code directly.

@laolarou726
minor fix
3ce8b46 
using new C# grammar
fix nullable warnings
using BitConverter for hash compute
update Nuget
code cleanup
@laolarou726
Copy link
Contributor Author

Just did more fix for the project

@SKProCH
Copy link
Member

SKProCH commented Feb 1, 2023

Oh, okay, thanks. I think what i need to add .editorconfig to the project to stabilize all formatting rules for code. What do you think?

@laolarou726
Copy link
Contributor Author

Oh, okay, thanks. I think what i need to add .editorconfig to the project to stabilize all formatting rules for code. What do you think?

Agree, currently I'm using the default lint rules in Resharper.

@SKProCH SKProCH merged commit 35fa3e4 into AvaloniaUtils:avalonia11 Feb 4, 2023
@laolarou726
Copy link
Contributor Author

@SKProCH It seems you forgot to publish a release for this merge. Can you create a new release on Nuget? Thanks!

@SKProCH
Copy link
Member

SKProCH commented Feb 6, 2023

Oh, in current project releases are triggered by tag... So, yes, my fault. I launched pipeline. Thanks, @laolarou726 )

@SKProCH
Copy link
Member

SKProCH commented Feb 6, 2023

I should unify all scripts in my libraries...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laolarou726 @SKProCH