Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added region code support #220

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Added region code support #220

merged 1 commit into from
Jun 2, 2021

Conversation

Avasam
Copy link
Owner

@Avasam Avasam commented Jun 2, 2021

  • Extended countryCode field in DB
  • Get region code first, fallback to country code
  • Add an endpoint to get users filtered by region (for NoReset)
  • Removed Japanese name support as it's now always null
  • Ensured if a flag doesn't exist for a region, that it would fallback to showing the parent region's flag
  • Fixed country code not being set for new users
  • This also lays the logical foundations for Custom filter by region / flags #146

@Avasam
Added region code support
99e5931 
- Extended countryCode field in DB
- Get region code first, fallback to country code
- Add an endpoint to get users filtered by region (for NoReset)
- Removed Japanese name support as it's now always null
- Ensured if a flag doesn't exist for a region, that it would fallback to showing the parent region's flag
- Fixed country code not being set for new users
- This also lays the logical foundations for #146
@Avasam Avasam merged commit a0e4c01 into develop Jun 2, 2021
@Avasam Avasam deleted the search-players-by-countryCode-endpoint branch February 19, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avasam