Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:[#58] #113

Closed
wants to merge 2 commits into from
Closed

FIX:[#58] #113

wants to merge 2 commits into from

Conversation

Madhavdua
Copy link
Contributor

Closes:

  • Title : UI improvements and minor fixes
  • Name: Madhav
  • SSOC contributor

Give a clear description of what have you added or modifications made
I have improved UI, Restructured some elements i.e instead of having complete code in one file, seperate components like searchbar.jsx etc.
Fixed negative episode search

Type of change ☑️

  • [ x] Bug fix : Episode will be searched only for positive value
  • [ x] New feature : updated UI
  • [ x] Code style update: Restructured some elements i.e instead of having complete code in one file, seperate components like searchbar.jsx etc.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [ x] This PR does not contain plagiarized content.
  • [x ] I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • [x ] My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-06-12 134129
Screenshot 2024-06-12 134216

Note to reviewers 📄

Instead of passing of props, using context Api should be used.

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 8:15am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavdua It's looks good. But you have linked your issue with the pr and resolve conflicts.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 14, 2024
@Madhavdua
Copy link
Contributor Author

So, should i raise another pull request without linking the issue?

@Avdhesh-Varshney
Copy link
Owner

@Madhavdua no you have link your issue with your pr. It's mandatory. But don't remove wave animation of bg. Keep it same. Also after doing any changes, format the file code.
Raise another pr as there are so much conflicts in the files.

@Avdhesh-Varshney Avdhesh-Varshney added wontfix ❌ This will not be worked on and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants