Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Footer #116

Closed
wants to merge 4 commits into from
Closed

Added Footer #116

wants to merge 4 commits into from

Conversation

narayani9120
Copy link

Closes: #60

Title : Added Footer to the website
Name: Narayani . S
Github Profile Name: narayani9120
Idenitfy yourself: I am GSSOC'24 Contributor

Describe the add-ons or changes you've made 📃

Adding footer to the website such that the footer it contains the social media links so that the user can contact and if they wish to add a episode they can add it with the help of admins. The work of adding episodes can be simplified for that the footer section would be beneficial. So for this purpose I added a footer page to the website with all possibilities to contact the admin.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

Note to reviewers 📄

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 4:48am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narayani9120 pr can't approved. because

  • you have committed in the main branch
  • UI of footer is not looks good.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working wontfix ❌ This will not be worked on labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Footer to the website
2 participants