Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some feature #117

Closed
wants to merge 1 commit into from
Closed

Add some feature #117

wants to merge 1 commit into from

Conversation

PriyanshuValiya
Copy link

@PriyanshuValiya PriyanshuValiya commented Jun 13, 2024

Closes:

Describe the add-ons or changes you've made πŸ“ƒ

Give a clear description of what have you added or modifications made

Type of change β˜‘οΈ

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: β˜‘οΈ

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots πŸ“·

Note to reviewers πŸ“„

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
chanakya βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 13, 2024 7:04am

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyanshuValiya but you are targeting for writing conclusion and storing it in local storage?
This can't be approved.

@Avdhesh-Varshney Avdhesh-Varshney added bug πŸ› Something isn't working Requested Changes βš™οΈ Some changes have been requested in this PR labels Jun 14, 2024
@PriyanshuValiya
Copy link
Author

We have to create a local data file and write all conclusions in an array form like you are created quotes file. And Render it with the Conclusion Component which was created by me.

@Avdhesh-Varshney
Copy link
Owner

@PriyanshuValiya leave it. Not required.

@Avdhesh-Varshney Avdhesh-Varshney added invalid 🚫 This doesn't seem right and removed Requested Changes βš™οΈ Some changes have been requested in this PR labels Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug πŸ› Something isn't working invalid 🚫 This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants