Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:[#58] - (2) #125

Closed
wants to merge 10 commits into from
Closed

Conversation

Madhavdua
Copy link
Contributor

Closes:

  • Title : UI improvements
  • Name: Madhav
  • SSOC contributor

Give a clear description of what have you added or modifications made
I have made the below changes with the required bg wave animation and file formatting.
I have improved UI, Restructured some elements i.e instead of having complete code in one file, seperate components like searchbar.jsx etc.
Fixed negative episode search

Type of change ☑️

  • [ x] Bug fix : Episode will be searched only for positive value
  • [ x] New feature : updated UI
  • [ x] Code style update: Restructured some elements i.e instead of having complete code in one file, seperate components like searchbar.jsx etc.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • [ x] This PR does not contain plagiarized content.
  • [x ] I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • [x ] My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-06-15 131849
Screenshot 2024-06-15 131913

Note to reviewers 📄

Instead of passing of props, using context Api should be used.
For which, should i raise an issue for it?

Copy link

vercel bot commented Jun 15, 2024

@Madhavdua is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavdua i think you have not updating your forked repo. That's why there are alots of conflicts in this pr, either resolve them or re-raise your pr after updating your repo.

This makes hard to review the pr.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 16, 2024
@Madhavdua
Copy link
Contributor Author

I have carefully resolved all conflicts. Kindly preview them.

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:54am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhavdua still there are some files where double quotes is un-necessarly updated by single quotes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

un-necessary change, remove this new created line

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work on the ui as it's not good ux.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work on the ui as it's not good ux.

image

Sir, i don't know why you are getting this UI, i have attached SS of UI i made.Kindly help me understand the issue.
Screenshot 2024-06-15 131849
Screenshot 2024-06-17 003351

@Madhavdua
Copy link
Contributor Author

Kindly update me sir.

@Avdhesh-Varshney
Copy link
Owner

@Madhavdua now it's looks nice. link. But this will remove the contribution of others from the website like quotes generation and many more things.

@Madhavdua
Copy link
Contributor Author

I understand.
The quote section is still present in code and i will display it properly in future updates.
The other major difference is the input (Search box), which i'll be working on to integrate and will soon update the branch.
Kindly tell me any futher requirements (if any).

@Avdhesh-Varshney
Copy link
Owner

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Madhavdua have you joined this server? Because due to my inactivity, this project is moving in a loooop. So, join it to get notify with the project upcoming changes and guidelines.

@Madhavdua
Copy link
Contributor Author

Hey @Avdhesh-Varshney i have integrated new feature and the quote section is not displayed yet, it may be added in future updates.
For now, it is the final update, it can be merged safely, once previewed.
Screenshot 2024-06-19 222221
Screenshot 2024-06-19 222259

@Avdhesh-Varshney
Copy link
Owner

@Madhavdua leave it. Start working on other new issues and move with the flow of project.

@Avdhesh-Varshney Avdhesh-Varshney added wontfix ❌ This will not be worked on and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 21, 2024
@Madhavdua Madhavdua deleted the ui-changes branch June 24, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants