-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX:[#58] - (2) #125
FIX:[#58] - (2) #125
Conversation
@Madhavdua is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Madhavdua i think you have not updating your forked repo. That's why there are alots of conflicts in this pr, either resolve them or re-raise your pr after updating your repo.
This makes hard to review the pr.
I have carefully resolved all conflicts. Kindly preview them. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Madhavdua still there are some files where double quotes is un-necessarly updated by single quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
un-necessary change, remove this new created line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly update me sir. |
@Madhavdua now it's looks nice. link. But this will remove the contribution of others from the website like quotes generation and many more things. |
I understand. |
@Madhavdua have you joined this server? Because due to my inactivity, this project is moving in a loooop. So, join it to get notify with the project upcoming changes and guidelines. |
Hey @Avdhesh-Varshney i have integrated new feature and the quote section is not displayed yet, it may be added in future updates. |
@Madhavdua leave it. Start working on other new issues and move with the flow of project. |
Closes:
Give a clear description of what have you added or modifications made
I have made the below changes with the required bg wave animation and file formatting.
I have improved UI, Restructured some elements i.e instead of having complete code in one file, seperate components like searchbar.jsx etc.
Fixed negative episode search
Type of change ☑️
Checklist: ☑️
Screenshots 📷
Note to reviewers 📄
Instead of passing of props, using context Api should be used.
For which, should i raise an issue for it?