Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added saved playback episode state #127

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

Mayureshd-18
Copy link
Contributor

@Mayureshd-18 Mayureshd-18 commented Jun 15, 2024

Closes: #123

  • Title : Added functionality to save the playback episode state
  • Name: Mayuresh
  • Idenitfy yourself: GSSOC, SSOC

Describe the add-ons or changes you've made 📃

Added functionality that will open the same episode on reloading the website or after closing and opening the website on which the user was. Use of local storage to add this functionality and browser cache

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Before closing:
image
After reopening the website:
image

Note to reviewers 📄

Copy link

vercel bot commented Jun 15, 2024

@Mayureshd-18 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2024 5:46pm

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mayureshd-18 update your code only but you have converted double quotes to single quotes.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 16, 2024
@Mayureshd-18
Copy link
Contributor Author

@Avdhesh-Varshney Done. Please review

Regards

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mayureshd-18 PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney merged commit 2023604 into Avdhesh-Varshney:main Jun 16, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request gssoc These issue/pull request will be considered for GSSOC'24 level3 Advanced level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request gssoc These issue/pull request will be considered for GSSOC'24 level3 Advanced level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: remembering playback state
2 participants