Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error 404 #149

Closed
wants to merge 0 commits into from
Closed

error 404 #149

wants to merge 0 commits into from

Conversation

taneeshaa15
Copy link

Hi @Avdhesh-Varshney ,
I hope you're doing well. I've addressed the issue #145 and created a pull request to resolve it.
Could you please review the PR and let me know if any adjustments are needed?

Best regards,
Tanisha Garg

Copy link

vercel bot commented Jun 24, 2024

@taneeshaa15 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:07am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taneeshaa15 i think you know this is an react project not a static website. That's why your pr is not deployed and don't change settings.json file.

Always create pr on your new branch not on main branch.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 24, 2024
@taneeshaa15
Copy link
Author

@Avdhesh-Varshney I changed the files to react files, please review and tell me what more adjustments are needed.

@Avdhesh-Varshney
Copy link
Owner

image

where is your 404 page?

@taneeshaa15
Copy link
Author

@Avdhesh-Varshney Will look into this issue and fix it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants