Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After starting app margin needs to be done between header message and content #36 #99

Merged
merged 3 commits into from
Jun 11, 2024
Merged

After starting app margin needs to be done between header message and content #36 #99

merged 3 commits into from
Jun 11, 2024

Conversation

kapilG0
Copy link
Contributor

@kapilG0 kapilG0 commented Jun 8, 2024

Closes: #36

  • Title : Contributor
  • Name: Kapil Gupta
  • Idenitfy yourself: SSOC,GSSOC

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image

Note to reviewers 📄

@vercel Vercel
Copy link

vercel bot commented Jun 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 2:46am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@kapilG0 kapilG0 mentioned this pull request Jun 8, 2024
Closed
Avdhesh-Varshney
Avdhesh-Varshney requested changes Jun 8, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Still shows same issue.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 8, 2024
@kapilG0
Copy link
Contributor Author

kapilG0 commented Jun 9, 2024

image Still shows same issue.

Ok let me check again

@kapilG0
Copy link
Contributor Author

kapilG0 commented Jun 9, 2024

image Still shows same issue.

Ok let me check again

Hello @Avdhesh-Varshney please check now i have fixed that and commit my code again in same pr

Avdhesh-Varshney
Avdhesh-Varshney requested changes Jun 9, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kapilG0 try to solve it with the presence of timeout operation.
And the change the title of the pr same as issue

src/App.jsx Outdated Show resolved Hide resolved
@kapilG0 kapilG0 changed the title https://github.com/Avdhesh-Varshney/Chanakya-Niti/issues/36 After starting app margin needs to be done between header message and content #36 Jun 10, 2024
@kapilG0
Copy link
Contributor Author

kapilG0 commented Jun 10, 2024

@kapilG0 try to solve it with the presence of timeout operation. And the change the title of the pr same as issue

Hello @Avdhesh-Varshney thank you for your response i have added that and update header

Avdhesh-Varshney
Avdhesh-Varshney approved these changes Jun 11, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kapilG0 PR Approved 🎉
But for next time, don't do un-necessary changes without discussing.

@Avdhesh-Varshney Avdhesh-Varshney merged commit cc56349 into Avdhesh-Varshney:main Jun 11, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added Approved ✔️ This PR is approved by the PR or, Mentors Beginner Beginner level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 bug 🐛 Something isn't working and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney approved these changes

Assignees

@kapilG0 kapilG0

Labels
Approved ✔️ This PR is approved by the PR or, Mentors Beginner Beginner level issues/pull requests bug 🐛 Something isn't working SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After starting app margin needs to be done between header message and content
2 participants
@kapilG0 @Avdhesh-Varshney