Skip to content

Commit

Permalink
Merge pull request #81 from Avivbens/fix-web-node-devops-tags
Browse files Browse the repository at this point in the history 
fix(profiles): change `devops` to be dependent on `engineering`, fix `web` <=> `node`
  • Loading branch information
@Avivbens
Avivbens authored Apr 22, 2024
2 parents 3e2792a + afa60c3 commit 2dbc440
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 29 deletions.
12 changes: 6 additions & 6 deletions src/commands/install/config/apps-groups/cli-apps.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const CLI_APPS: Readonly<IAppSetup[]> = [
name: 'NVM',
description: 'Node Version Manager',
group: 'cli-apps',
tags: ['node-engineering', 'devops'],
tags: ['node-engineering', 'web-engineering', 'devops'],
commands: () => [
BREW_INSTALL('nvm'),
'\\. "$(brew --prefix)/opt/nvm/nvm.sh"',
Expand All @@ -37,15 +37,15 @@ export const CLI_APPS: Readonly<IAppSetup[]> = [
name: 'GitHub CLI',
group: 'cli-apps',
description: 'GitHub in your terminal',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_INSTALL('gh')],
fallbackCommands: () => [BROW_INSTALL('gh')],
},
{
name: 'google-cloud-sdk',
group: 'cli-apps',
description: 'Integrate with Google Cloud Platform services, Python is required',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_CASK('google-cloud-sdk')],
fallbackCommands: () => [BROW_CASK('google-cloud-sdk')],
deps: ['Python'],
Expand All @@ -69,7 +69,7 @@ export const CLI_APPS: Readonly<IAppSetup[]> = [
name: 'Mongodb',
group: 'cli-apps',
description: 'MongoDB Community Edition server',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_TAP('mongodb/brew'), BREW_INSTALL('mongodb-community@6.0'), 'mkdir -p "$HOME/mongodb"'],
fallbackCommands: () => [
BROW_TAP('mongodb/brew'),
Expand All @@ -81,15 +81,15 @@ export const CLI_APPS: Readonly<IAppSetup[]> = [
name: 'Redis',
description: 'Redis server',
group: 'cli-apps',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_INSTALL('redis')],
fallbackCommands: () => [BROW_INSTALL('redis')],
},
{
name: 'Docker',
description: 'Docker CLI',
group: 'cli-apps',
tags: ['devops'],
tags: ['node-engineering', 'devops'],
commands: () => [BREW_INSTALL('docker')],
},
{
Expand Down
7 changes: 3 additions & 4 deletions src/commands/install/config/apps-groups/engineering-apps.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ export const ENGINEERING_APPS: Readonly<IAppSetup[]> = [
{
name: 'Mongodb Compass',
group: 'engineering-apps',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_CASK('mongodb-compass')],
description: 'MongoDB GUI, MongoDB is required',
},
{
name: 'Another Redis Desktop Manager',
group: 'engineering-apps',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [
BREW_CASK('another-redis-desktop-manager'),
`sudo xattr -rd com.apple.quarantine "/Applications/Another Redis Desktop Manager.app"`,
Expand All @@ -23,14 +23,13 @@ export const ENGINEERING_APPS: Readonly<IAppSetup[]> = [
name: 'Rancher',
description: 'Kubernetes and Docker UI tool',
group: 'engineering-apps',
tags: ['engineering', 'devops'],
commands: () => [BREW_CASK('rancher')],
},
{
name: 'Postman',
description: 'API client',
group: 'engineering-apps',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_CASK('postman')],
},
]
2 changes: 1 addition & 1 deletion src/commands/install/config/apps-groups/git.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const GIT_APPS: Readonly<IAppSetup[]> = [
name: 'Git',
description: 'Common Code Version Manager',
group: 'git',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_INSTALL('git')],
},
{
Expand Down
4 changes: 2 additions & 2 deletions src/commands/install/config/apps-groups/ides.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ export const IDES: Readonly<IAppSetup[]> = [
{
name: 'Visual Studio Code',
group: 'IDEs',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_CASK('visual-studio-code')],
},
{
name: 'Webstorm',
group: 'IDEs',
tags: ['web-engineering'],
tags: ['web-engineering', 'node-engineering'],
paid: true,
commands: () => [BREW_CASK('webstorm')],
},
Expand Down
32 changes: 18 additions & 14 deletions src/commands/install/config/apps-groups/node.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,56 +11,55 @@ export const NODE_APPS: Readonly<IAppSetup[]> = [
{
name: '@nestjs/cli',
group: 'node',
tags: ['web-engineering'],
tags: ['node-engineering'],
commands: () => [NODE_GLOBAL('@nestjs/cli')],
},
{
name: 'nx',
group: 'node',
tags: ['web-engineering'],
tags: ['web-engineering', 'node-engineering'],
commands: () => [NODE_GLOBAL('nx')],
},
{
name: 'jest',
group: 'node',
tags: ['web-engineering', 'node-engineering'],
commands: () => [NODE_GLOBAL('jest')],
},
{
name: 'ts-jest',
group: 'node',
tags: ['web-engineering'],
commands: () => [NODE_GLOBAL('ts-jest')],
},
{
name: 'ts-node-dev',
group: 'node',
tags: ['web-engineering'],
tags: ['node-engineering'],
commands: () => [NODE_GLOBAL('ts-node-dev')],
},
{
name: 'ts-node',
group: 'node',
tags: ['web-engineering'],
tags: ['node-engineering'],
commands: () => [NODE_GLOBAL('ts-node')],
},
{
name: 'typescript',
group: 'node',
tags: ['web-engineering'],
tags: ['web-engineering', 'node-engineering'],
commands: () => [NODE_GLOBAL('typescript')],
},
{
name: '@githubnext/github-copilot-cli',
group: 'node',
tags: ['web-engineering', 'devops'],
commands: () => [NODE_GLOBAL('@githubnext/github-copilot-cli')],
},
{
name: 'nodemon',
group: 'node',
tags: ['web-engineering'],
tags: ['node-engineering'],
commands: () => [NODE_GLOBAL('nodemon')],
},
{
name: 'npmrc',
description: 'manage multiple .npmrc files effortlessly',
group: 'node',
tags: ['web-engineering', 'devops'],
tags: ['web-engineering', 'node-engineering', 'devops'],
commands: () => [NODE_GLOBAL('npmrc')],
},
{
Expand Down Expand Up @@ -120,6 +119,11 @@ export const NODE_APPS: Readonly<IAppSetup[]> = [
group: 'node',
commands: () => [NODE_GLOBAL('prettier')],
},
{
name: '@githubnext/github-copilot-cli',
group: 'node',
commands: () => [NODE_GLOBAL('@githubnext/github-copilot-cli')],
},
{
name: 'vercel',
group: 'node',
Expand Down
4 changes: 2 additions & 2 deletions src/commands/install/config/apps-groups/terminal.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ export const TERMINAL_APPS: Readonly<IAppSetup[]> = [
{
name: 'ZSH Terminal Syntax Highlighting',
group: 'terminal',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_INSTALL('zsh-syntax-highlighting')],
fallbackCommands: () => [BROW_INSTALL('zsh-syntax-highlighting')],
},
{
name: 'ZSH Terminal Syntax Autosuggestions',
group: 'terminal',
tags: ['engineering', 'devops'],
tags: ['engineering'],
commands: () => [BREW_INSTALL('zsh-autosuggestions')],
fallbackCommands: () => [BROW_INSTALL('zsh-autosuggestions')],
},
Expand Down
1 change: 1 addition & 0 deletions src/models/tag.model.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@ export const TAGS_DEPS: Partial<Record<ITag, ITag[]>> = {
'python-engineering': ['engineering'],
'node-engineering': ['engineering'],
'web-engineering': ['engineering'],
devops: ['engineering'],
'super-user': ['productivity'],
}

0 comments on commit 2dbc440

Please sign in to comment.