Fixed AVnu certification test failure 6.1a and 6.3a #177
Conversation
Rejects Announce message with sourcePortIdentity same as my own AVnu certification test 6.3a - PASS Rejects Path Trace TLV with ClockIdentity same as mine Implemented PathTraceTLV Parsing Implemented PathTraceTLV Append/Search Operations Added debug (print method) to ClockIdentity class Corrected misc output format (printf), indentation issues
| identityList.end(); | ||
| } | ||
| int length() { | ||
| return 2*sizeof(uint16_t) + PTP_CLOCK_IDENTITY_LENGTH*identityList.size(); |
There was a problem hiding this comment.
comment on magic 2* would be good. I'm guessing sizeof(tlvType) + sizeof(length)?
There was a problem hiding this comment.
I'll add a comment
|
This is just a general comment/suggestion for future reference, rather than something you should put into this commit: I like to encapsulate the formatting of data into byte buffers/byte streams into a small library of functions that handle the writing of data, byte-order conversions (if necessary), and buffer position pointer management. This tends to make the functions that read/write various program data into the buffers much clearer and less error-prone, especially when you get into interactions of bit fields, byte order, and data field alignment. Casting arbitrary byte buffer positions to/from larger types can cause misaligned access exceptions on some architectures. E.g., from the ARM compiler support FAQ: "The compiler will generate code on the assumption that a pointer is correctly aligned." Most v7 ARM processors you're likely to run this on do support unaligned access, but notably Cortex-M processors still do not. |
|
MRP could benefit from pdu buffer read/write functions as well. I added as a wish to TWiki page. |
Minor formatting changes
Fixed AVnu certification test failure 6.1a and 6.3a
Rejects Announce message with sourcePortIdentity same as my own
AVnu certification test 6.3a - PASS
Rejects Path Trace TLV with ClockIdentity same as mine
Implemented PathTraceTLV Parsing
Implemented PathTraceTLV Append/Search Operations
Added debug (print method) to ClockIdentity class
Corrected misc output format (printf), indentation issues