Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gptp doc task #221

Merged
merged 25 commits into from
May 30, 2015
Merged

Gptp doc task #221

merged 25 commits into from
May 30, 2015

Conversation

davidcemin
Copy link
Contributor

No description provided.

@andrew-elder
Copy link

Mostly all looks fine. It does seem strange to have "Makefile" listed in gptp .gitignore. If I can make a suggestion, I think we should create a "build" subdir of gptp then go
cd build
cmake ..
and then we can just have "build" in our base .gitignore and do not worry about listing any files that are created when cmake runs. The whole idea of cmake is to support building from an out-of-tree location, so I think we should make use of that way of operating.

Anyone else have comments?

@davidcemin
Copy link
Contributor Author

Andrew,

sounds better. Should we integrate that pull request first ? Or i can just
fix that on the same branch and we integrate it on the same pull request...

let me know.

David

On Fri, May 29, 2015 at 9:04 AM, andrew-elder notifications@github.com
wrote:

Mostly all looks fine. It does seem strange to have "Makefile" listed in
gptp .gitignore. If I can make a suggestion, I think we should create a
"build" subdir of gptp then go
cd build
cmake ..
and then we can just have "build" in our base .gitignore and do not worry
about listing any files that are created when cmake runs. The whole idea of
cmake is to support building from an out-of-tree location, so I think we
should make use of that way of operating.

Anyone else have comments?


Reply to this email directly or view it on GitHub
#221 (comment).

@andrew-elder
Copy link

ChrisH reported via email that he is ok with this pull request!

andrew-elder pushed a commit that referenced this pull request May 30, 2015
@andrew-elder andrew-elder merged commit dda934a into Avnu:open-avb-next May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants