Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon_cl: Fixes PPS out-of-phase issue. #333

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

rhii
Copy link
Contributor

@rhii rhii commented Dec 15, 2015

From I210 datasheet section
7.8.3.3.3 "Synchronized Output Clock on SDP Pins":
The clock out drives initially a logical '0' level on the selected SDP.
If the TSAUXC.ST0/1 flag is cleared, it happens instantly when setting the
TSAUXC.EN_CLK0/1 bit.
Otherwise it happens when the SYSTIM is >= the TRGTTIM.

Before the fix, when stopping PPS, only the SDP pin is disabled.
Therefore when starting PPS again, as soon as the SDP pin is enabled,
the clock output starts.

This fix will correctly clear the TSAUXC.ST0/1 and TSAUXC.EN_CLK0/1 bits
when stopping PPS. This will ensure that the clock output only happen
when the SYSTIM is >= the TRGTTIM.

Signed-off-by: Roland Hii roland.king.guan.hii@intel.com

From I210 datasheet section
7.8.3.3.3 "Synchronized Output Clock on SDP Pins":
The clock out drives initially a logical '0' level on the selected SDP.
If the TSAUXC.ST0/1 flag is cleared, it happens instantly when setting the
TSAUXC.EN_CLK0/1 bit.
Otherwise it happens when the SYSTIM is >= the TRGTTIM.

Before the fix, when stopping PPS, only the SDP pin is disabled.
Therefore when starting PPS again, as soon as the SDP pin is enabled,
the clock output starts.

This fix will correctly clear the TSAUXC.ST0/1 and TSAUXC.EN_CLK0/1 bits
when stopping PPS. This will ensure that the clock output only happen
when the SYSTIM is >= the TRGTTIM.

Signed-off-by: Roland Hii <roland.king.guan.hii@intel.com>
@andrew-elder
Copy link

This looks good to me. @christopher-s-hall - are you ok with it?

@christopher-s-hall
Copy link
Contributor

Please give me a day or two to review this.

@christopher-s-hall
Copy link
Contributor

This looks OK. I say yes.

@andrew-elder
Copy link

Thanks @christopher-s-hall !

andrew-elder pushed a commit that referenced this pull request Dec 16, 2015
daemon_cl: Fixes PPS out-of-phase issue.
@andrew-elder andrew-elder merged commit 3fb708f into Avnu:open-avb-next Dec 16, 2015
@rhii rhii deleted the open-avb-next branch December 17, 2015 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants