Fix logic for starting PDelay sending #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. David? |
|
Looks good to me as well. EDIT: Haha, just realized you probably mean David Cemin and not me. |
|
@DMATS - someone is going to test the patch a little tomorrow before we merge. |
|
The code looks good to me too. But im still having trouble with the tests. |
|
If we can put this off till tomorrow it would be great, so I will leave it running overnight. |
|
There are some errors but I judge that they should be addressed separately. I will go ahead and integrate it since open-avb-next is broken today without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The else clause was attached to the wrong if condition; as a result, sending of PDelay messages only worked when the automotive profile was enabled. Without PDelay transactions, the peer would never be asCapable and the rest of the protocol would never run.
I have verified that it does send PDelay requests when this patch is applied.