Memory leak #426
Merged
Memory leak #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cket. Signed-off-by: Windriver Yong-heon.Kim <yong-heon.kim@windriver.com>
Signed-off-by: Windriver Yong-heon.Kim <yong-heon.kim@windriver.com>
|
These changes look ok to me. Anyone else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch fixes memory leak that occurs when receive unexpected message in PTP packet.
In addition, checking transportSpecifit needs to be done after calling getRxTimestamp().
If buildPTPMessage() is returned before calling getRxTimeStamp() rxTimestampList will keep increasing in LinuxTimestamperGeneric class.
The second patch removes to assign duplicated InterfaceName object unnecessarily.
And this also occurs memory leak.