Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gPTP Fixes and Improvements #434

Merged
merged 10 commits into from
Jul 26, 2016
Merged

Conversation

kencarlino
Copy link
Contributor

Here is another set of fixes and improvements for gPTP with the focus on the automotive profile. See the list of commits for more information about what is changed.

@andrew-elder
Copy link

This looks ok to me. Is anyone in a position to run it?

@pinealservo
Copy link
Contributor

I am (will be) in a position to run it; I'm in the middle of a long-run test right now, so I'll try it tomorrow.

( this, SYNC_RECEIPT_TIMEOUT_EXPIRES,
(SYNC_RECEIPT_TIMEOUT_MULTIPLIER*
(unsigned long long)(pow((double)2,getSyncInterval())*1000000000.0)));*/
/* TODO : Seems this be active here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we would ever want a sync receipt timer running while we're grandmaster. Should probably be deleted unless someone knows a good reason for it to continue to stick around as a comment.

@pinealservo
Copy link
Contributor

Ugh, my comments aren't really on outdated diffs; I was just viewing a commit at a time. In any case, I didn't find anything that would prevent merging, I just looked into some of the "TODO" commented out code, so you might want to un-collapse and look at my previous comments.

I have run it in both normal and automotive profile mode, and it seems to be working correctly, though I haven't run exhaustive tests.

@pinealservo
Copy link
Contributor

Thanks for cleaning up that comment, @kencarlino. I think we've had enough eyes on this now, and I've verified basic functionality in both standard and automotive profile mode.

@pinealservo pinealservo merged commit 9364a67 into Avnu:open-avb-next Jul 26, 2016
@andrew-elder
Copy link

Thanks for merging @pinealservo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants