-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gPTP Fixes and Improvements #434
Conversation
This looks ok to me. Is anyone in a position to run it? |
I am (will be) in a position to run it; I'm in the middle of a long-run test right now, so I'll try it tomorrow. |
( this, SYNC_RECEIPT_TIMEOUT_EXPIRES, | ||
(SYNC_RECEIPT_TIMEOUT_MULTIPLIER* | ||
(unsigned long long)(pow((double)2,getSyncInterval())*1000000000.0)));*/ | ||
/* TODO : Seems this be active here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why we would ever want a sync receipt timer running while we're grandmaster. Should probably be deleted unless someone knows a good reason for it to continue to stick around as a comment.
Ugh, my comments aren't really on outdated diffs; I was just viewing a commit at a time. In any case, I didn't find anything that would prevent merging, I just looked into some of the "TODO" commented out code, so you might want to un-collapse and look at my previous comments. I have run it in both normal and automotive profile mode, and it seems to be working correctly, though I haven't run exhaustive tests. |
Thanks for cleaning up that comment, @kencarlino. I think we've had enough eyes on this now, and I've verified basic functionality in both standard and automotive profile mode. |
Thanks for merging @pinealservo! |
Here is another set of fixes and improvements for gPTP with the focus on the automotive profile. See the list of commits for more information about what is changed.