Fixes to gPTP signaling message TLV values #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed as Malformed due to an incorrect value for the LengthField. As defined in 802.1AS 2011 section 10.5.4.3.3 LengthField the length value shall be 12. Currently gPTP is sending an incorrect value of 28. Additionally for the signaling message TLV: Organization Subtype is 0x1 in the packet but it should be 0x2 LinkDelayInterval is 0x0 but for the Automotive Profile should be 127 Flags field is 0x0 in the packet but should be 0x3
|
This change looks ok to me. Anyone else? |
|
Looks like the right thing to me. |
|
Thanks @christopher-s-hall, I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Wireshark 2.0.5 the signaling message in gPTP is reported as Malformed due to an incorrect value for the LengthField.
As defined in 802.1AS 2011 section 10.5.4.3.3 LengthField the length value shall be 12.
Currently gPTP is sending an incorrect value of 28.
Additionally for the signaling message TLV:
Organization Subtype is 0x1 in the packet but it should be 0x2
LinkDelayInterval is 0x0 but for the Automotive Profile should be 127
Flags field is 0x0 in the packet but should be 0x3